Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hpp-fclConfig.cmake on Windows #633

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Nov 29, 2024

Use IMPLIB instead of LOCATION on Windows

@jorisv jorisv self-assigned this Nov 29, 2024
@jorisv jorisv force-pushed the topic/fix_hpp_fcl_windows branch from d6b020d to ed5df40 Compare November 29, 2024 10:43
@jorisv jorisv force-pushed the topic/fix_hpp_fcl_windows branch from ed5df40 to bf525f7 Compare December 2, 2024 15:15
nim65s
nim65s previously approved these changes Dec 2, 2024
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good enough, as long as nobody try to patch the install location of this file, between paths that have a different number of subdirs AND want to keep the compat layer.

@jorisv jorisv marked this pull request as ready for review December 3, 2024 14:02
@jorisv jorisv requested a review from nim65s December 3, 2024 14:03
@jorisv jorisv merged commit 7bf2cfa into coal-library:devel Dec 4, 2024
34 checks passed
@jorisv jorisv deleted the topic/fix_hpp_fcl_windows branch December 4, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants